Skip to content

SeriesInfoExtractorServiceImpl.extractCategory(): add unit tests for filtering invalid names #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Jan 19, 2018 · 0 comments
Closed

SeriesInfoExtractorServiceImpl.extractCategory(): add unit tests for filtering invalid names #822

0pdd opened this issue Jan 19, 2018 · 0 comments
Assignees
@php-coder
Labels
area/unit tests techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Jan 19, 2018

The puzzle 821-87f36dcd from #821 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java

Line 108 in f8eee29

// @todo #821 SeriesInfoExtractorServiceImpl.extractCategory(): add unit tests for filtering invalid names

The puzzle was created by Slava Semushin on 19-Jan-18.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Jan 19, 2018
0pdd referenced this issue Jan 19, 2018
@php-coder
/series/import/request: allow URLs longer than 285 characters.
f8eee29 
Update validation to match the database.

Correction for 33dd902 commit.

Addressed to #772
@php-coder php-coder added this to the 0.4 milestone Jul 15, 2018
@php-coder php-coder self-assigned this Oct 18, 2018
0pdd referenced this issue Oct 18, 2018
@php-coder
test(SeriesInfoExtractorServiceImpl.extractCountry): add unit tests f…
23eb703 
…or filtering invalid names.

Fix #823

No functional changes.
@0pdd 0pdd mentioned this issue Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd