Skip to content

Series import: filter out invalid candidates #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jan 19, 2018 · 1 comment
Closed

Series import: filter out invalid candidates #821

php-coder opened this issue Jan 19, 2018 · 1 comment
Assignees
@php-coder
Labels
kind/bug trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 19, 2018 •
edited
Loading

We should filter out candidates with short names because otherwise they can match when we'll use LIKE and leads to a wrong category:

r.m.w.s.SeriesInfoExtractorServiceImpl   : Determining category from a fragment: 'ДАГОМЕЯ ? М? ДОИСТОРИЧЕСКАЯ ФАУНА ДИНОЗАВРЫ АВИАПОЧТА 3 БЕЗЗУБЦОВЫЕ МАРКИ С ПОЛЯМИ КУПИТЬ! (39)'
r.m.w.s.SeriesInfoExtractorServiceImpl   : Possible candidates: [С, М?, ФАУНА, (39), 3, БЕЗЗУБЦОВЫЕ, ПОЛЯМИ, ДОИСТОРИЧЕСКАЯ, ДИНОЗАВРЫ, МАРКИ, АВИАПОЧТА, ДАГОМЕЯ, ?, КУПИТЬ!]
r.m.w.s.SeriesInfoExtractorServiceImpl   : Found categories: []
r.m.w.s.SeriesInfoExtractorServiceImpl   : Possible candidate: 'С%'
r.m.w.s.SeriesInfoExtractorServiceImpl   : Found categories: [2]

The result is wrong because 2 is id of the Sport category, while I expect that it should found "Prehistoric animals" category.

Also let's filter out candidates with long names.

Perhaps, after fixing #819 it will find "Prehistoric animals" category from the first attempt (via aliases) and won't produce wrong result (because it won't do lookup with LIKE).
@php-coder php-coder added this to the next milestone Jan 19, 2018
@php-coder php-coder self-assigned this Jan 19, 2018
@php-coder php-coder modified the milestones: next, 0.4 Jan 19, 2018
php-coder added a commit that referenced this issue Jan 19, 2018
@php-coder
SeriesInfoExtractorServiceImpl: refactor code to use Stream API for g…
d7f899a 
…etting unique candidates.

Prerequsite to #821

No functional changes.
php-coder added a commit that referenced this issue Jan 19, 2018
@php-coder
SeriesInfoExtractorServiceImpl: refactor code to use Stream API for g…
1c0d64f 
…etting unique candidates.

Prerequsite to #821

No functional changes.
@php-coder php-coder changed the title Series import: filter out short candidates Series import: filter out invalid candidates Jan 19, 2018
php-coder added a commit that referenced this issue Jan 19, 2018
@php-coder
SeriesInfoExtractorServiceImpl: rename local variable (candidates -> …
290e6f1 
…names).

Follow-up to #821

No functional changes.
php-coder added a commit that referenced this issue Jan 19, 2018
@php-coder
SeriesInfoExtractorServiceImpl: rename local variable (uniqueCandidat…
e70ece3 
…es -> candidates).

Follow-up to #821

No functional changes.
This was referenced Jan 19, 2018
Closed
Closed
@0pdd
Copy link

0pdd commented Oct 18, 2018

@php-coder all 2 puzzles are solved here: #822, #823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd