Skip to content

SeriesImportServiceImpl.saveParsedData(): handle exception gracefully #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Nov 7, 2017 · 0 comments
Closed

SeriesImportServiceImpl.saveParsedData(): handle exception gracefully #684

php-coder opened this issue Nov 7, 2017 · 0 comments
Assignees
@php-coder
Labels
kind/improvement techdebt
Milestone
0.4

Comments

@php-coder
Copy link
Owner

mystamps/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java

Lines 150 to 151 in 29f6dc9

// TODO: handle it gracefully by publishing ParsingFailed event
Validate.validState(processedData.hasAtLeastOneFieldFilled(), "");

Tech debt for 29f6dc9 (#660)
@php-coder php-coder self-assigned this Dec 4, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 4, 2017
@0pdd 0pdd mentioned this issue Dec 4, 2017
Closed
php-coder added a commit that referenced this issue Dec 5, 2017
@php-coder
SeriesImportServiceImpl: fix unit tests.
0789b3b 
Correction for 4ed41b4 commit.

Addressed to #684
@0pdd 0pdd mentioned this issue Dec 6, 2017
Open
php-coder added a commit that referenced this issue Jun 22, 2023
@php-coder
ci: manually update puzzle id after changing a comment
6cc36cc 
The comment has been modified in 947f7b2 commit

The error was:
ERROR: 684-0b0d5497 => #748: issue looks identical but its body doesn't contain the puzzle id (684-0b0d5497)!
ERROR: Perhaps, the puzzle id got changed after issue creation
ERROR: Body: The puzzle 684-b075a77e (from #684) in [src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java](https://github.com/php-coder/mystamps/blob/6091f30a29dc445f8f544cc05e359df910c67eb5/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java#L182-L183) has to be resolved: "Series import: add integration test for the case when parsed value don't match database"  https://github.com/php-coder/mystamps/blob/6091f30a29dc445f8f544cc05e359df910c67eb5/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java#L182-L183  The puzzle was created by Slava Semushin on 04-Dec-17
ERROR: Ways to resolve:
ERROR:     1) edit #748 and modify its body to contain 684-0b0d5497
ERROR:     2) manually create a mapping between this puzzle and the issue:
ERROR:        echo '684-0b0d5497\t748\topen\tmanually' >>generated-todos/todos-on-github.tsv

Part of #1610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/improvement techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder