Import series: gracefully handle the case when parsed value don't match database.

Fix #684

Author: php-coder

src/main/java/ru/mystamps/web/config/ServicesConfig.java

@@ -21,6 +21,7 @@
 
 import org.slf4j.LoggerFactory;
 
+import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.context.MessageSource;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -44,6 +45,7 @@ public class ServicesConfig {
 	private final JavaMailSender mailSender;
 	private final Environment env;
 	private final MessageSource messageSource;
+	private final ApplicationEventPublisher eventPublisher;
 
 	@Bean
 	public SuspiciousActivityService getSuspiciousActivityService() {
@@ -166,7 +168,8 @@ public SeriesImportService getSeriesImportService() {
 			LoggerFactory.getLogger(SeriesImportServiceImpl.class),
 			daoConfig.getSeriesImportDao(),
 			getSeriesService(),
-			getSeriesInfoExtractorService()
+			getSeriesInfoExtractorService(),
+			eventPublisher
 		);
 	}
 

src/main/java/ru/mystamps/web/controller/event/ParsingFailed.java

@@ -23,6 +23,12 @@
 
 /**
  * Event occurs when parsing of a file from import request has been failed.
+ *
+ * It could occurs by 2 reasons:
+ * - when we couldn't extract anything meaningful
+ *   (elements specified by locators don't contain info)
+ * - when we extract information but were unable to match it with database
+ *   (for example, we extracted country named "Italy" but it doesn't exist in database)
  */
 @Getter
 public class ParsingFailed extends ApplicationEvent {

src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java

@@ -25,13 +25,15 @@
 
 import org.slf4j.Logger;
 
+import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.transaction.annotation.Transactional;
 
 import org.springframework.security.access.prepost.PreAuthorize;
 
 import lombok.RequiredArgsConstructor;
 
 import ru.mystamps.web.Db.SeriesImportRequestStatus;
+import ru.mystamps.web.controller.event.ParsingFailed;
 import ru.mystamps.web.dao.SeriesImportDao;
 import ru.mystamps.web.dao.dto.ImportRequestDto;
 import ru.mystamps.web.dao.dto.ImportSeriesDbDto;
@@ -51,6 +53,7 @@ public class SeriesImportServiceImpl implements SeriesImportService {
 	private final SeriesImportDao seriesImportDao;
 	private final SeriesService seriesService;
 	private final SeriesInfoExtractorService extractorService;
+	private final ApplicationEventPublisher eventPublisher;
 
 	@Override
 	@Transactional
@@ -175,8 +178,13 @@ public void saveParsedData(Integer requestId, RawParsedDataDto data) {
 			processedData.setReleaseYear(releaseYear);
 		}
 
-		// TODO: handle it gracefully by publishing ParsingFailed event
-		Validate.validState(processedData.hasAtLeastOneFieldFilled(), "");
+		// IMPORTANT: don't add code that modifies database above this line!
+		// @todo #684 Series import: add integration test
+		//  for the case when parsed value don't match database
+		if (!processedData.hasAtLeastOneFieldFilled()) {
+			eventPublisher.publishEvent(new ParsingFailed(this, requestId));
+			return;
+		}
 
 		seriesImportDao.addParsedContent(requestId, processedData);