Skip to content

Replace JPA/Hibernate by JDBC/JdbcTemplate #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
29 tasks done
php-coder opened this issue Jul 24, 2015 · 2 comments
Closed
29 tasks done

Replace JPA/Hibernate by JDBC/JdbcTemplate #120

php-coder opened this issue Jul 24, 2015 · 2 comments
Assignees
@php-coder
Labels
area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file impact/deploy Manual actions will be required during deployment refactoring
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 24, 2015 •
edited
Loading

  • Remove entities with their repositories:
    • Category
    • Collection
    • Country
    • Currency
    • GibbonsCatalog
    • Image
    • ImageData
    • MichelCatalog
    • ScottCatalog
    • Series
    • SuspiciousActivity
    • SuspiciousActivityType
    • User
    • UsersActivation
    • YvertCatalog
    • LocalizedEntity
    • MetaInfo
    • Price
    • StampsCatalog
  • Other:
    • remove Hibernate/JPA dependencies (don't forget about xml-apis)
    • remove settings from application.properties
    • remove src/main/resources/META-INF/persistence.xml
    • revise TestObjects helper
    • rename Dao interfaces (dao.JdbcFooDao -> dao.FooDao) and classes (dao.impl.JdbcFooDaoImpl -> dao.impl.FooDaoImpl)
    • update list of excluded auto configurations
    • measure speed improvements (run tests) and size of war
    • move constants from entities to Db class (?)
    • move classes from service.dto to dao.dto (cd src/main/java/ru/mystamps/web/dao; git grep -h service.dto |sort -u)
    • update README.md/NEWS.txt
@php-coder php-coder mentioned this issue Jul 25, 2015
Closed
php-coder added a commit that referenced this issue Sep 9, 2015
@php-coder
Port country creation from JPA to JDBC.
ab95ef6 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 9, 2015
@php-coder
Port category creation from JPA to JDBC.
dcffa75 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 9, 2015
@php-coder
JdbcCollectionDao.add(): use DTO instead of entity as argument.
04a8240 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 11, 2015
@php-coder
SeriesService.countSeriesOf(): change argument from Collection to Int…
2c0fda1 
…eger.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 11, 2015
@php-coder
SeriesService.countStampsOf(): change argument from Collection to Int…
39269f5 
…eger.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 11, 2015
@php-coder
SeriesService.findBy(Category): renamed to findByCategoryId() to repl…
d9254f8 
…ace usage of Category entity.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 11, 2015
@php-coder
SeriesService.findBy(Collection): renamed to findByCollectionId() to …
6f8f655 
…replace usage of Collection entity.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 11, 2015
@php-coder
SeriesService.findBy(Country): renamed to findByCountryId() to replac…
c6aec5b 
…e usage of Country entity.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 13, 2015
@php-coder
CollectionService.isSeriesInCollection(): port from JPA to JDBC.
7e1c172 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 13, 2015
@php-coder
CollectionService.addToCollection(): port from JPA to JDBC.
79a6a9e 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 13, 2015
@php-coder
CollectionService.removeFromCollection(): port from JPA to JDBC.
33a7067 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 14, 2015
@php-coder
CollectionService.createCollection(): change arguments to getting rid…
a167169 
… of usage of User entity.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 15, 2015
@php-coder
CategoryService.countCategoriesOf(): change argument from Collection …
c330118 
…to Integer.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 15, 2015
@php-coder
CategoryService.getStatisticsOf(): change argument from Collection to…
e7397b0 
… Integer.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 15, 2015
@php-coder
CountryService.countCountriesOfCollection(): change argument from Col…
80509b3 
…lection to Integer.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 15, 2015
@php-coder
CountryService.getStatisticsOf(): change argument from Collection to …
6b82c16 
…Integer.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 17, 2015
@php-coder
CategoryService.add(): change argument from User to Integer.
d5503ea 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 17, 2015
@php-coder
CountryService.add(): change argument from User to Integer.
55b0f34 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Sep 21, 2015
@php-coder
UsersActivationService.remove(): change argument from UsersActivation…
f3d7bae 
… to String.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Oct 16, 2015
@php-coder
JdbcUsersActivationDao.add(): change argument from UsersActivation to…
1a9f38f 
… AddUsersActivationDbDto.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Oct 17, 2015
@php-coder
UsersActivationService.findByActivationKey(): change return value fro…
bdc632d 
…m UsersActivation to UsersActivationDto.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Oct 17, 2015
@php-coder
Replace usage of UsersActivation.ACTIVATION_KEY_LENGTH by ValidationR…
4fc7b63 
…ules.ACT_KEY_LENGTH.

Addressed to #120

No functional changes.
@php-coder php-coder self-assigned this Nov 25, 2015
php-coder added a commit that referenced this issue Dec 8, 2015
@php-coder
category/info.html: put to context separate variables instead of sing…
ae3ca6d 
…le object.

Make view not aware of structure and type of the object (entity/dto/etc) and also allow to easy
determine where and what methods of the object were used.

Related to #120
php-coder added a commit that referenced this issue Dec 8, 2015
@php-coder
country/info.html: put to context separate variables instead of singl…
4e86525 
…e object.

Make view not aware of structure and type of the object (entity/dto/etc) and also allow to
easy determine where and what methods of the object were used.

Related to #120
php-coder added a commit that referenced this issue Dec 9, 2015
@php-coder
CategoryController.showInfo(): replace Category by LinkEntityDto.
aff0bf7 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Mar 15, 2016
@php-coder
Replace User by Integer in controllers' arguments.
ff2baf6 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Mar 20, 2016
@php-coder
UserService.findByLogin(): replace by findUserDetailsByLogin().
90203c7 
Addressed to #120

No functional changes.
@php-coder php-coder added the impact/deploy Manual actions will be required during deployment label Apr 9, 2016
php-coder added a commit that referenced this issue Apr 9, 2016
@php-coder
UserServiceImpl.registerUser(): port to JDBC.
57bc795 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 9, 2016
@php-coder
ValidationRules: inline constant.
7fa1008 
Removed last reference to User entity.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 10, 2016
@php-coder
DatabaseImagePersistenceStrategy.get(): replace usage of ImageData.
4dca489 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 16, 2016
@php-coder
DatabaseImagePersistenceStrategy.save(): replace usage of ImageData.
3a2e9c6 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 16, 2016
@php-coder
DatabaseImagePersistenceStrategy: rename a member.
8024fda 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 16, 2016
@php-coder
ImagePersistenceStrategy.save(): replace usage of Image.
b19bcef 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue Apr 16, 2016
@php-coder
ImagePersistenceStrategy.get(): replace usage of Image.
7bb1907 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
ImageServiceImpl.get(): get rid of Image usage.
860047d 
Addresed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
ImageServiceImpl.save(): get rid of Image.
b4d5304 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
Remove Spring-Data-JPA DAO classes.
0c050d8 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
Remove JPA entities.
e3038c3 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
Final removal of Hibernate/Spring-Data-JPA.
682c251 
This change removes 16 JARs from dependencies and also makes WAR lighter on 8Mb. Also it
reduces startup time on about 2-3 seconds on my MacBook.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 1, 2016
@php-coder
Move some DTO classes from service.dto to dao.dto package.
8bd7390 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcCategoryDao and JdbcCategoryDaoImpl renamed to CategoryDao and Jd…
e0b2652 
…bcCategoryDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcCountryDao and JdbcCountryDaoImpl renamed to CountryDao and JdbcC…
b49e51f 
…ountryDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcCollectionDao and JdbcCollectionDaoImpl renamed to CollectionDao …
27b6d32 
…and JdbcCollectionDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcImageDao and JdbcImageDaoImpl renamed to ImageDao and JdbcImageDao.
63e1ec5 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcImageDataDao and JdbcImageDataDaoImpl renamed to ImageDataDao and…
561f2e7 
… JdbcImageDataDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcSeriesDao and JdbcSeriesDaoImpl renamed to SeriesDao and JdbcSeri…
9a1d55c 
…esDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcUserDao and JdbcUserDaoImpl renamed to UserDao and JdbcUserDao.
33971c9 
Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
JdbcUsersActivationDao and JdbcUsersActivationDaoImpl renamed to User…
426c16a 
…sActivationDao and JdbcUsersActivationDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 2, 2016
@php-coder
Jdbc{Gibbons,Michel,Scott,Yvert}CatalogDaoImpl renamed to Jdbc{Gibbon…
0fe74bd 
…s,Michel,Scott,Yvert}CatalogDao.

Addressed to #120

No functional changes.
php-coder added a commit that referenced this issue May 3, 2016
@php-coder
application-*.properties: exclude Hibernate and Spring-Data autoconfi…
73355af 
…guration classes.

Addressed to #120

No functional changes.
@php-coder
Copy link
Owner Author

The following changes for application-prod.properties are required:

@php-coder
Copy link
Owner Author

It's finally fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/infrastructure impact/changelog This change should be reflected in the NEWS.txt file impact/deploy Manual actions will be required during deployment refactoring
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder