Skip to content

Commit 8024fda

Browse files
committed
DatabaseImagePersistenceStrategy: rename a member.
Addressed to #120 No functional changes.
1 parent 3a2e9c6 commit 8024fda

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

src/main/java/ru/mystamps/web/service/DatabaseImagePersistenceStrategy.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class DatabaseImagePersistenceStrategy implements ImagePersistenceStrateg
4040
private static final Logger LOG =
4141
LoggerFactory.getLogger(DatabaseImagePersistenceStrategy.class);
4242

43-
private final JdbcImageDataDao jdbcImageDataDao;
43+
private final JdbcImageDataDao imageDataDao;
4444

4545
@PostConstruct
4646
public void init() {
@@ -54,7 +54,7 @@ public void save(MultipartFile file, Image image) {
5454
imageData.setImageId(image.getId());
5555
imageData.setContent(file.getBytes());
5656

57-
Integer id = jdbcImageDataDao.add(imageData);
57+
Integer id = imageDataDao.add(imageData);
5858
LOG.info("Image's data #{} for image #{} have been saved", id, image.getId());
5959

6060
} catch (IOException e) {
@@ -65,7 +65,7 @@ public void save(MultipartFile file, Image image) {
6565

6666
@Override
6767
public ImageDto get(Image image) {
68-
DbImageDto imageDto = jdbcImageDataDao.findByImageId(image.getId());
68+
DbImageDto imageDto = imageDataDao.findByImageId(image.getId());
6969
if (imageDto == null) {
7070
LOG.warn("Found image without content: #{}", image.getId());
7171
return null;

src/test/groovy/ru/mystamps/web/service/DatabaseImagePersistenceStrategyTest.groovy

+7-8
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,11 @@ import ru.mystamps.web.service.exception.ImagePersistenceException
2929

3030
class DatabaseImagePersistenceStrategyTest extends Specification {
3131

32-
private JdbcImageDataDao jdbcImageDataDao = Mock()
32+
private JdbcImageDataDao imageDataDao = Mock()
3333
private MultipartFile multipartFile = Mock()
3434
private Image image = TestObjects.createImage()
3535

36-
private ImagePersistenceStrategy strategy =
37-
new DatabaseImagePersistenceStrategy(jdbcImageDataDao)
36+
private ImagePersistenceStrategy strategy = new DatabaseImagePersistenceStrategy(imageDataDao)
3837

3938
//
4039
// Tests for save()
@@ -58,7 +57,7 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
5857
when:
5958
strategy.save(multipartFile, image)
6059
then:
61-
1 * jdbcImageDataDao.add({ AddImageDataDbDto imageData ->
60+
1 * imageDataDao.add({ AddImageDataDbDto imageData ->
6261
assert imageData?.content == expected
6362
return true
6463
})
@@ -70,7 +69,7 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
7069
when:
7170
strategy.save(multipartFile, image)
7271
then:
73-
1 * jdbcImageDataDao.add({ AddImageDataDbDto imageData ->
72+
1 * imageDataDao.add({ AddImageDataDbDto imageData ->
7473
assert imageData?.imageId == expectedImageId
7574
return true
7675
})
@@ -89,15 +88,15 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
8988
when:
9089
strategy.get(image)
9190
then:
92-
1 * jdbcImageDataDao.findByImageId({ Integer imageId ->
91+
1 * imageDataDao.findByImageId({ Integer imageId ->
9392
assert imageId == expectedImageId
9493
return true
9594
})
9695
}
9796

9897
def "get() should return null when image data dao returned null"() {
9998
given:
100-
jdbcImageDataDao.findByImageId(_ as Integer) >> null
99+
imageDataDao.findByImageId(_ as Integer) >> null
101100
when:
102101
ImageDto result = strategy.get(image)
103102
then:
@@ -108,7 +107,7 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
108107
given:
109108
ImageDto expectedImageDto = TestObjects.createDbImageDto()
110109
and:
111-
jdbcImageDataDao.findByImageId(_ as Integer) >> expectedImageDto
110+
imageDataDao.findByImageId(_ as Integer) >> expectedImageDto
112111
when:
113112
ImageDto result = strategy.get(image)
114113
then:

0 commit comments

Comments
 (0)