-
Notifications
You must be signed in to change notification settings - Fork 34
Make React related integration tests work #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
At this moment, they fail with:
Most likely, this will be fixed with a new version of Selenium and htmlunit (see #1001) |
No, it wasn't or at least not fully.
This one can be workarounded with --- src/main/frontend/src/components/SeriesSaleImportForm.js
+++ src/main/frontend/src/components/SeriesSaleImportForm.js
@@ -40,9 +40,10 @@ class SeriesSaleImportForm extends React.Component {
validationErrors: []
});
- const headers = new Headers();
- headers.set('Content-Type', 'application/json; charset=UTF-8');
- headers.set(this.props.csrfHeaderName, this.props.csrfTokenValue);
+ const headers = new Headers([
+ [ 'Content-Type', 'application/json; charset=UTF-8' ],
+ [ this.props.csrfHeaderName, this.props.csrfTokenValue ]
+ ]);
const request = new Request(
this.props.url, But after that there will be another error: |
We can try to use axios instead or wait until #966 will be solved. |
With axios everything works except |
… import tests pass under htmlunit. Workaround for HtmlUnit/htmlunit#78 Part of #1072
… with empty required field" test. Allow to user to submit an empty field in order to be able to validate server-side validation. Part of #1072
…mlunit bug. sendKeys() was failing with "StringIndexOutOfBoundsException: start > length()" exception when we fill a field a second time. Opening a page on every test fixes that as there is no state left from a previous test. Workaround for HtmlUnit/htmlunit#142 Part of #1072
Done. |
The puzzle
1057-d01039f1
from #1057 has to be resolved:mystamps/pom.xml
Line 1061 in 6b40dca
The puzzle was created by @php-coder on 23-Jun-19.
The text was updated successfully, but these errors were encountered: