Skip to content

Commit 99ab8f2

Browse files
committed
chore: document decisions and remove a tag as AJAX-related tests pass now.
Part of #1072 [skip ci]
1 parent 943afba commit 99ab8f2

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

docs/decisions-log.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@
55
| 09.02.2020 Workaround | **pdd** fails to parse files in charsets other than UTF-8 with error `invalid byte sequence in UTF-8`. Workaround: exclude `src/test/wiremock` directory. Bug: [yegor256/pdd#143](https://github.com/yegor256/pdd/issues/143) Commits: [30aab7d](https://github.com/php-coder/mystamps/commit/30aab7dc8c265804efef382422e7cae9e53187f3), [ab563b6](https://github.com/php-coder/mystamps/commit/ab563b653279625120121babccdfd915181ee46d) |
66
| 07.02.2020 Workaround | [php-coder/mystamps#1248](https://github.com/php-coder/mystamps/issues/1248): **wiremock** logs warnings for static resources when there is no stub mapping. Workaround: create mappings for such resources. Bug: [tomakehurst/wiremock#1247](https://github.com/tomakehurst/wiremock/issues/1247) Commits: [0018ad4](https://github.com/php-coder/mystamps/commit/0018ad44a21379b8179f94e954795c66b6d50bbc) |
77
| 24.11.2019 Workaround | [php-coder/mystamps#1156](https://github.com/php-coder/mystamps/issues/1156) After updating **html5validator** to 0.3.2, the `--ignore-re` has stopped to work. Workaround: revert and pin the version to 0.3.1 Bug: [svenkreiss/html5validator#64](https://github.com/svenkreiss/html5validator/issues/64) Commits: [9a0d695](https://github.com/php-coder/mystamps/commit/9a0d695ccac1deeba0c4280779bbac11ebf3ac4d) |
8+
| 07.03.2020 Workaround | [php-coder/mystamps#1072](https://github.com/php-coder/mystamps/issues/1072): AJAX-related tests don't work in **htmlunit** and fail with `ReferenceError: "Headers" is not defined`. When the code got updated to use another version of constructor of `Headers` class, tests fail with error `ReferenceError: "fetch" is not defined` error. Bug: [HtmlUnit/htmlunit#78](https://github.com/HtmlUnit/htmlunit/issues/78) Workaround: because "the fetch api is not supported so far", let's use axios library instead. Commits: [f224e94](https://github.com/php-coder/mystamps/commit/f224e944b367036458ce9d7ce0c596504766ef8e) |
9+
| 07.03.2020 Workaround | [php-coder/mystamps#1072](https://github.com/php-coder/mystamps/issues/1072): `sendKeys()` method from **htmlunit** fails with `StringIndexOutOfBoundsException: start > length()` exception when we fill a field again. Bug: [HtmlUnit/htmlunit#142](https://github.com/HtmlUnit/htmlunit/issues/142) Workaround: open a page on every test to avoid a state from other tests. Commits: [943afba](https://github.com/php-coder/mystamps/commit/943afba4f60b3df47e678a274186b80702e7562c) |

pom.xml

-2
Original file line numberDiff line numberDiff line change
@@ -1098,8 +1098,6 @@
10981098
<nonCriticalTags>
10991099
<!-- Allow to tests with this tag to fail without changing final status -->
11001100
<nonCriticalTag>unstable</nonCriticalTag>
1101-
<!-- @todo #1057 Make React related integration tests work -->
1102-
<nonCriticalTag>react-related</nonCriticalTag>
11031101
</nonCriticalTags>
11041102
</configuration>
11051103
<dependencies>

src/test/robotframework/series/sales/import/logic.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Resource ../../../selenium.utils.robot
66
Suite Setup Before Test Suite
77
Suite Teardown Close Browser
88
Test Setup Before Test
9-
Force Tags series sales import-sales logic react-related
9+
Force Tags series sales import-sales logic
1010

1111
*** Test Cases ***
1212
Import a series sale with an existing seller

src/test/robotframework/series/sales/import/validation.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Resource ../../../selenium.utils.robot
66
Suite Setup Before Test Suite
77
Suite Teardown Close Browser
88
Test Setup Before Test
9-
Force Tags series sales import-sales validation react-related
9+
Force Tags series sales import-sales validation
1010

1111
*** Test Cases ***
1212
Import a series sale with empty required field

0 commit comments

Comments
 (0)