Skip to content

Consider disabled SSL flag in ConnectionFactoryOptions #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Consider disabled SSL flag in ConnectionFactoryOptions #460

wants to merge 1 commit into from

Conversation

govi20
Copy link
Contributor

@govi20 govi20 commented Oct 23, 2021

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

In the existing logic, we are setting SSLMode to VERIFY_FULL when the SSL option is added by the user. As part of this PR adding a check to ensure that SSL flag is set as true.

see #453

@mp911de mp911de changed the title [#453] add handling for SSL flag Consider disabled SSL flag in ConnectionFactoryOptions Oct 26, 2021
mp911de pushed a commit that referenced this pull request Oct 26, 2021
@govi20 @mp911de
Consider disabled SSL flag in ConnectionFactoryOptions
9dff92c 
[resolves #453][#460]
mp911de added a commit that referenced this pull request Oct 26, 2021
@mp911de
Polishing.
dd07bc4 
Reformat code.

[#453][resolves #460]

Signed-off-by: Mark Paluch <[email protected]>
mp911de pushed a commit that referenced this pull request Oct 26, 2021
@govi20 @mp911de
Consider disabled SSL flag in ConnectionFactoryOptions
7b00a2b 
[resolves #453][#460]
@mp911de mp911de closed this in 40c2be0 Oct 26, 2021
@mp911de
Copy link
Collaborator

mp911de commented Oct 26, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de added the type: bug A general bug label Oct 26, 2021
@mp911de mp911de added this to the 0.8.11.RELEASE milestone Oct 26, 2021
@mp911de mp911de linked an issue Oct 26, 2021 that may be closed by this pull request
SSL=False Option isn't working #453
Closed
@wallace1 wallace1 mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
0.8.11.RELEASE
Development

Successfully merging this pull request may close these issues.

SSL=False Option isn't working
2 participants
@govi20 @mp911de