SSL=False Option isn't working

[florianrusch]

Bug Report

Versions

• Driver: Postgres
• Database: Postgres 13
• Java: 11

Current Behavior

We define the SSL ConnectionFactoryOption as false, but it is not recognized. It is always assumed to be true.

class R2dbcConfig() {
	fun r2dbcConnectionFactory(): ConnectionFactory {
		val options = ConnectionFactoryOptions.builder()
			.option(ConnectionFactoryOptions.HOST, "postgres")
			.option(ConnectionFactoryOptions.PORT, 5432)
			.option(ConnectionFactoryOptions.DATABASE, "postgres")
			.option(ConnectionFactoryOptions.USER, "")
			.option(ConnectionFactoryOptions.PASSWORD, "")
			.option(ConnectionFactoryOptions.DRIVER, "postgresql")
			.option(ConnectionFactoryOptions.PROTOCOL, "r2dbc")
			.option(ConnectionFactoryOptions.SSL, false)            <-------
			.build()

		val connectionFactory = ConnectionFactories.get(options)
		val pool = ConnectionPoolConfiguration.builder(connectionFactory)
			.acquireRetry(10)
			.build()

		return ConnectionPool(pool)
	}
}

Stack trace

Caused by: io.r2dbc.postgresql.client.AbstractPostgresSSLHandlerAdapter$PostgresqlSslException: Server support for SSL connection is disabled, but client was configured with SSL mode verify-full

Expected behavior/code

If ConnectionFactoryOptions.SSL was set to be false then the ssl mode should be "disable".

Possible Solution

Change this logic to handle true/false values:

r2dbc-postgresql/src/main/java/io/r2dbc/postgresql/PostgresqlConnectionFactoryProvider.java

Line 290 in 5a5ac38

mapper.from(SSL).to(builder::enableSsl);

[mp911de]

Thanks for the report. That's indeed a bug. Do you want to submit a pull request to fix the issue?