Support for geospatial types - point, line, box, polygon etc #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mp911de
reviewed
Jul 28, 2020
| */ | ||
| public final class Line { | ||
|
|
||
| private final double a; |
There was a problem hiding this comment.
We should add a bit of Javadoc to the fields.
| this.c = c; | ||
| } | ||
|
|
||
| public static Line of(double a, double b, double c) { |
There was a problem hiding this comment.
Would it make sense to add factory methods accepting two points or even x1/y1, x2/y2?
|
@mp911de thanks for the review. I updated the |
mp911de
added a commit
that referenced
this pull request
Jul 31, 2020
Add javadoc to factory methods. Add since tags. Use consistently String.format(…) for toString. Fix Path equals and hashCode. Add license headers. Introduce TokenStream to avoid repeated Double.parse(…) calls. Fix binary representation of Path.open as in Postgres the protocol transmits of the Path is closed so we need to negate the flag. [closes #306][#282]
7 tasks
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #282