Skip to content

feature: adding support for lseg type #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

avinash-anand
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

related to issue previously opened support for geometric types - #282

New Public APIs

Additional context

@avinash-anand
Copy link
Contributor Author

@mp911de - please review and let me know if something needs improvement.

@mp911de
Copy link
Collaborator

mp911de commented Jul 27, 2020

Thanks a lot. We received a pull request that brings support for all remaining geo types, see #306. Since the other pull request duplicates this one and completes the geo type story, I'm inclined to close this one in favor of #306. What do you think?

@avinash-anand
Copy link
Contributor Author

Thanks a lot. We received a pull request that brings support for all remaining geo types, see #306. Since the other pull request duplicates this one and completes the geo type story, I'm inclined to close this one in favor of #306. What do you think?

@mp911de - sure. I can close this PR.
I have another question - Can I open separate issue for support for postgis plugin data types? Is this repo good place for those data type codecs?

@mp911de
Copy link
Collaborator

mp911de commented Jul 27, 2020

Thanks a for your feedback. Postgis for JDBC is part of an external library. I'd advise to follow the same design for R2DBC. With CodecRegistry in place, any external library can provide an extension through Java's ServiceLoader mechanism so that the driver is going to pick it up. Reaching out to the maintainers of https://github.com/postgis/postgis-java would be a good idea to keep all Postgis code in a single place.

@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply status: duplicate A duplicate of another issue labels Jul 27, 2020
@avinash-anand avinash-anand deleted the issue-282-lseg branch July 27, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants