BUG: Fix for cython version checking closes #9827 #9881
Closed
+70
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate travis builds to test.
|
merged via a134759 thanks! |
|
@jreback Is it needed to have that many extra travis envs in the build matrix? Won't that slow down the travis checking of PRs? |
|
@jorisvandenbossche only 2 extra and they are really quick. (and in the allowed fails anyhow) |
|
in the .yml you have to duplicate things if you want them to allowed to fail (e.g. once in the definitions and once in the allowed fails section), |
|
@jreback Ah, OK, that last info was what I didn't know :-) otherwise it looked like a lot extra in the non-allowed to fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9827
Added a cython version check at the top of setup.py; minimum version of 0.19.1. If the minimum isn't met, _CYTHON_INSTALLED sets to false, so the installation can proceed if cython is not needed, but will fail if cython is needed (with an appropriate error message).
Two new travis jobs added to test install_conda and install_pydata flows for the old cython revision, and ensure that pandas setup fails with appropriate error messages. See https://travis-ci.org/ajamian/pandas/builds/58315862 for regression.