Skip to content

add Cython version as a pip dependency #9827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drevicko opened this issue Apr 7, 2015 · 9 comments
Closed

add Cython version as a pip dependency #9827

drevicko opened this issue Apr 7, 2015 · 9 comments
Labels
Build Library building on various platforms
Milestone

Comments

@drevicko
Copy link

drevicko commented Apr 7, 2015

When I tried to pip install pandas on a system with cython 0.15.1, it failed (I'm guessing that's not surprising). After pip installing cython (to 0.22), pandas installs fine. The error messages talked about missing lib.pxd and tslib.pxd files - to my untrained eye, Cython wasn't an obvious culprit!

My point is that, unless there's a good reason not to, the minimum cython version for compiling pandas should be a dependency in pip.

@shoyer
Copy link
Member

shoyer commented Apr 7, 2015

Cython actually isn't an install requirement for pandas if you are using the pypi distribution (what you get from pip install pandas) -- it should install just fine without it. Frankly, I would think it should work even if you only have an older version of Cython installed... how did you install pandas?

@drevicko
Copy link
Author

drevicko commented Apr 7, 2015

pip install pandas from within a virtualenv with system-site-packages turned on.

@shoyer
Copy link
Member

shoyer commented Apr 7, 2015

Hmm. Looking through our setup.py file, it appears we attempt to build with Cython if it's installed without checking any minimum versions. That is indeed problematic -- the installation page mentions that cython 0.19.1 is required to build the dev version.

@jreback
Copy link
Contributor

jreback commented Apr 7, 2015

I suppose you could add this similarly to how numpy/pytz/dateutil are there. though the min version of cython is 0.19.1 is over 2 years old (and 0.15.1 is almost 4).

building with system installed libraries is not generally recommended, see the install instructions

@jreback jreback added Build Library building on various platforms Difficulty Novice labels Apr 7, 2015
@jreback jreback added this to the 0.16.1 milestone Apr 7, 2015
@drevicko
Copy link
Author

drevicko commented Apr 7, 2015

Yeah, it's an unusual case: a university server where I've not got sudo privelidges and Ubuntu 12.04 (with about 40 updates not installed! It's behind a firewall though..). Anyway, it's an easy fix and helpful for others in a similar situaion (:

@jreback
Copy link
Contributor

jreback commented Apr 7, 2015

@drevicko gr8 thanks!

@bashtage
Copy link
Contributor

bashtage commented Apr 7, 2015

@drevicko You might want to consider Anaconda (esp Miniconda as a starting point)

@ajamian
Copy link
Contributor

ajamian commented Apr 13, 2015

Attempting this as part of pycon sprints.

ajamian added a commit to ajamian/pandas that referenced this issue Apr 13, 2015
ajamian added a commit to ajamian/pandas that referenced this issue Apr 13, 2015
jreback pushed a commit to jreback/pandas that referenced this issue Apr 14, 2015
@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

closed by #9881

@jreback jreback closed this as completed Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants