BUG: Fix read_csv on S3 files for python 3 #9561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
force-pushed
the
s3_encoding
branch
from
1adbf92 to
41c8d56
Compare
|
Looks like there was already an existing test for reading from S3 :). |
|
Good thing too! I was going to test this at work on py2, so I would have caught it :) |
Needed to pass along encoding parameter. Bump boto version. Enable test on py3
TomAugspurger
force-pushed
the
s3_encoding
branch
from
41c8d56 to
73cc3c8
Compare
|
The failure cam from us using an old version of boto. The |
jreback
added
IO Data
jreback
added a commit
that referenced
this pull request
Mar 6, 2015
BUG: Fix read_csv on S3 files for python 3
|
thanks @TomAugspurger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9452
Needed to pass along encoding parameter.
No tests... Kind of hard since it's only s3 only.