Skip to content

BUG/COMPAT: io.common.get_filepath_or_buffer should use pass encoding parameter #9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TomAugspurger opened this issue Feb 9, 2015 · 1 comment · Fixed by #9561
Closed

BUG/COMPAT: io.common.get_filepath_or_buffer should use pass encoding parameter #9452

TomAugspurger opened this issue Feb 9, 2015 · 1 comment · Fixed by #9561
Labels
Compat pandas objects compatability with Numpy or Python functions IO Data IO issues that don't fit into a more specific label
Milestone
0.16.0

Comments

@TomAugspurger
Copy link
Contributor

Ran into this when downloading a file from s3 with py3.

This line needs to pass the encoding parameter to the boto method .get_contents_as_string, else it returns a stream of bytes which trips up StringIO on python 3.

Simple fix. Will try to get to it tonight unless someone beats me to it.
@TomAugspurger TomAugspurger added IO Data IO issues that don't fit into a more specific label Good as first PR Compat pandas objects compatability with Numpy or Python functions labels Feb 9, 2015
@TomAugspurger TomAugspurger added this to the 0.16.0 milestone Feb 9, 2015
@TomAugspurger
Copy link
Contributor Author

@cpcloud I don't think this will mess anything up with into. It seems that you are passing in encoding=utf-8 (which is correct for my case), but I don't really understand how into handles kwargs.

@TomAugspurger TomAugspurger mentioned this issue Feb 28, 2015
Merged
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

BUG: Fix read_csv on S3 files for python 3 TomAugspurger/pandas
2 participants
@jreback @TomAugspurger