ENH: Don't infer WOM-5MON if we don't support it (#9425) #9427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -926,7 +926,8 @@ def _get_wom_rule(self): | |||
| return None | |||
|
|
|||
| week_of_months = unique((self.index.day - 1) // 7) | |||
| if len(week_of_months) > 1: | |||
| week_of_months = week_of_months[week_of_months < 4] | |||
There was a problem hiding this comment.
can you add a comment here on what this does and referene the issue (so future readers will know).
|
pls add a release note. you can put in bug fixes for 0.17.0. looks good. pls ping when travis is green. |
|
@jreback build passed. let me know if there's anything else i can do |
shoyer
added a commit
that referenced
this pull request
May 30, 2015
ENH: Don't infer WOM-5MON if we don't support it (#9425)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9425