-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
'infer_freq' can return timerule (WOM-5MON) that 'to_offset' does not support #9425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
well the inferer is technically correct here. and the I think you could add a |
The problem comes up when pandas itself uses the inferred frequency here: https://github.com/pydata/pandas/blob/master/pandas/tseries/index.py#L823 If I go with your suggestion above, do you suggest I change the inferred_freq to strict? |
well I think its better to have |
ENH: Don't infer WOM-5MON if we don't support it (#9425)
* https://github.com/pydata/pandas: (26 commits) disable some deps on 3.2 build Fix meantim typo DOC: use current ipython in doc build PERF: write basic datetimes faster pandas-dev#10271 TST: fix for bottleneck >= 1.0 nansum behavior, xref pandas-dev#9422 add numba example to enhancingperf.rst BUG: SparseSeries constructor ignores input data name BUG: Raise TypeError only if key DataFrame is not empty pandas-dev#10126 ENH: groupby.apply for Categorical should preserve categories (closes pandas-dev#10138) DOC: add in whatsnew/0.17.0.txt DOC: move whatsnew from 0.17.0 -> 0.16.2 BUG: Holiday(..) with both offset and observance raises NotImplementedError pandas-dev#10217 BUG: Index.union cannot handle array-likes BUG: SparseSeries.abs() resets name BUG: Series arithmetic methods incorrectly hold name ENH: Don't infer WOM-5MON if we don't support it (pandas-dev#9425) BUG: Series.align resets name when fill_value is specified BUG: GroupBy.get_group raises ValueError when group key contains NaT Close mysql connection in TestXMySQL to prevent tests freezing BUG: plot doesnt default to matplotlib axes.grid setting (pandas-dev#9792) ...
* commit 'v0.16.1-97-gbc7d48f': (56 commits) disable some deps on 3.2 build Fix meantim typo DOC: use current ipython in doc build PERF: write basic datetimes faster pandas-dev#10271 TST: fix for bottleneck >= 1.0 nansum behavior, xref pandas-dev#9422 add numba example to enhancingperf.rst BUG: SparseSeries constructor ignores input data name BUG: Raise TypeError only if key DataFrame is not empty pandas-dev#10126 ENH: groupby.apply for Categorical should preserve categories (closes pandas-dev#10138) DOC: add in whatsnew/0.17.0.txt DOC: move whatsnew from 0.17.0 -> 0.16.2 BUG: Holiday(..) with both offset and observance raises NotImplementedError pandas-dev#10217 BUG: Index.union cannot handle array-likes BUG: SparseSeries.abs() resets name BUG: Series arithmetic methods incorrectly hold name ENH: Don't infer WOM-5MON if we don't support it (pandas-dev#9425) BUG: Series.align resets name when fill_value is specified BUG: GroupBy.get_group raises ValueError when group key contains NaT Close mysql connection in TestXMySQL to prevent tests freezing BUG: plot doesnt default to matplotlib axes.grid setting (pandas-dev#9792) ...
Instead of supporting WOM-5###, I think we can easily modify _get_wom_rule() to return None for this set of dates so it doesn't get inferred. Agree?
The text was updated successfully, but these errors were encountered: