API: restore full datetime.timedelta compat with Timedelta w.r.t. seconds/microseconds accessors (GH9185, GH9139) #9257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
API Design
Timedelta
|
I think this should bring us back to the previous behavior. |
| def seconds(self): | ||
| """ The number of integer seconds for each element """ | ||
| """ The number of integer total seconds for each element """ |
There was a problem hiding this comment.
'total' is also not fully correct in the sense it is only a part of the timedelta expressed in seconds.
The docstring of datetime.timedelta.seconds says it as " Number of seconds (>= 0 and less than 1 day)."
There was a problem hiding this comment.
And maybe add a reference to components to have only the seconds part
|
I think we also need to update the timedelta docs: http://pandas.pydata.org/pandas-docs/stable/timedeltas.html |
|
all comments have been addressed. |
jreback
force-pushed
the
td
branch
2 times, most recently
from
86c8c05 to
6e618d7
Compare
| @@ -27,6 +27,41 @@ Backwards incompatible API changes | |||
|
|
|||
| .. _whatsnew_0160.api_breaking: | |||
|
|
|||
| - In v0.15.0 a new scalar type ``Timedelta`` was introduced, that is a sub-class of ``datetime.timedelta``. Mentioned :ref:`here <whatsnew_0150.timedeltaindex>` was a notice of an API change w.r.t. the ``.seconds`` accessor. The intent was to provide a user-friendly set of accessors that give the 'natural' value for that unit, e.g. if you had a ``Timedelta('1 day, 10:11:12')``, then ``.seconds`` would return 12. However, this is at odds with the definition of ``datetime.timedelta``, which defines ``.seconds`` as ``10 * 3600 + 11 * 60 + 12 == 36672``. | |||
|
|
|||
| So in v0.16.0, we are restoring the API to match that of ``datetime.timedelta``. However, the component values are still available thru the ``.components`` accessor. This affects the ``.seconds`` and ``.microseconds`` accessors, and removes the ``.hours``, ``.minutes``, ``.milliseconds``, ``.nanoseconds`` accessors. These changes affect ``TimedeltaIndex`` and the Series ``.dt`` accessor as well. (:issue:`9185`, :issue:`9139`) | |||
There was a problem hiding this comment.
here is still nanoseconds as removed
jreback
force-pushed
the
td
branch
2 times, most recently
from
8c97b7a to
bf0354d
Compare
…onds/microseconds accessors (GH9185, GH9139) +
| # this is 5 minutes * 60 + 3 seconds | ||
| tds.to_pytimedelta().seconds | ||
|
|
||
| td.dt.components.seconds | ||
|
|
There was a problem hiding this comment.
sorry...was editing something else
|
OK, looks good to me! |
jreback
added a commit
that referenced
this pull request
Jan 16, 2015
API: restore full datetime.timedelta compat with Timedelta w.r.t. seconds/microseconds accessors (GH9185, GH9139)
|
Thanks Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9185
closes #9139