BUG: Fix for Timestamp handling in xlwt and xlsxwriter engines. #9175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, this seems ok. pls add a release note (bug fix section). |
Fix for writing Timestamp objects using the xlwt and xlsxwriter engines. Both modules write Excel dates and times using datetime.timedelta which differs from pandas.Timedelta. This fix coerces Timestamp objects to datetime objects. Issue #9139.
|
I've added a release note. Note 100% sure if it is in the correct place though. That is probably something that could be added to the Contributing.md doc as some stage. If it is wrong let me know and I'll fix it. Rebased and updated. John |
|
Release note is fine! |
|
see #9185. Going to steal your tests, but should work after that fix is done/merged. |
|
replaced by #9257 (tests only are necesssary) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for writing Timestamp objects using the xlwt and xlsxwriter
engines. Both modules write Excel dates and times using
datetime.timedelta which differs from pandas.Timedelta. This
fix coerces Timestamp objects to datetime objects.
fixes #9139.