BUG: Fixed font size (set it on both x and y axis). #8765 #8940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomAugspurger can you review this? |
dxe4
force-pushed
the
8765_bug_fontsize_only_on_x_axis
branch
from
826f862 to
c76ba87
Compare
|
@papaloizouc ready to merge if you could add a short note to |
| @@ -48,6 +48,14 @@ def test_ts_plot_with_tz(self): | |||
| ts = Series([188.5, 328.25], index=index) | |||
| _check_plot_works(ts.plot) | |||
|
|
|||
| def test_fontsize_set_correctly(self): | |||
| '''For issue #8765''' | |||
There was a problem hiding this comment.
Can you make this a # comment (docstring disguise the test name when running the tests, which is not really handy)
dxe4
force-pushed
the
8765_bug_fontsize_only_on_x_axis
branch
2 times, most recently
from
6d62a66 to
9f093c7
Compare
dxe4
force-pushed
the
8765_bug_fontsize_only_on_x_axis
branch
from
9f093c7 to
47a831e
Compare
|
Thanks! |
jorisvandenbossche
added a commit
that referenced
this pull request
Dec 1, 2014
…_axis BUG: Fixed font size (set it on both x and y axis). #8765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8765
The font size was only set on x axis if vertical or the y axis if horizontal.