Skip to content

BUG: fontsize parameter of plot only affects one axis. #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2014

Conversation

davidastephens
Copy link
Contributor

fixes #8765

import pandas as pd
df = pd.DataFrame(np.random.randn(10, 9), index=range(10))
df.plot(fontsize=7)

fig_fonts_all_same_size

@jreback
Copy link
Contributor

jreback commented Nov 11, 2014

@TomAugspurger have a look at this as well

@TomAugspurger
Copy link
Contributor

Agreed that this should be the default.

@dstephens99 Could you rebase? And while you're rebasing, could you change the docstring for fontsize to make it clear that the parameter affects x and y ticklabels?

@davidastephens
Copy link
Contributor Author

@TomAugspurger Done. Also specified that rotation only happens to the x ticks on a vertical plot and the y ticks on a horizontal plot.

@jreback
Copy link
Contributor

jreback commented Dec 4, 2014

@dstephens99 can you rebase

@TomAugspurger @jorisvandenbossche ?

@davidastephens
Copy link
Contributor Author

Apparently someone else's pull request was merged to fix this (#8940).

@jreback
Copy link
Contributor

jreback commented Dec 4, 2014

ahh I c; I think was done at the london hackathon ....

next time :)

@jreback jreback closed this Dec 4, 2014
@jorisvandenbossche
Copy link
Member

@dstephens99 Ah, sorry, didn't see your PR.
However, if you still want to rebase it, that would be valuable. The actual fix is the same, but you also fixed some docstrings and tests that were not in the other PR that still can go in (only the whatsnew entry you will have to remove, the rest should be ok after a rebase).

@jreback
Copy link
Contributor

jreback commented Dec 6, 2014

@dstephens99 can ypu rebase / update according to @jorisvandenbossche comment. thanks

@davidastephens
Copy link
Contributor Author

@jreback Green and good to go on this one.

jorisvandenbossche added a commit that referenced this pull request Dec 10, 2014
BUG: fontsize parameter of plot only affects one axis.
@jorisvandenbossche jorisvandenbossche merged commit 53682e3 into pandas-dev:master Dec 10, 2014
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.15.2, 0.16.0 Dec 10, 2014
@jorisvandenbossche
Copy link
Member

@dstephens99 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: fontsize parameter of plot only affects x-axis.
4 participants