Skip to content

TST: Moving testing method outside of TestCase #8104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

TST: Moving testing method outside of TestCase #8104

wants to merge 2 commits into from

Conversation

bwignall
Copy link
Contributor

Make assert_numpy_array_equal available without subclassing TestCase; see #8023

Make assert_numpy_array_equal available without subclassing TestCase; see #8023
@bwignall
Copy link
Contributor Author

If this is not along the lines of what you have in mind for #8023, please feel free to close this.

@jreback
Copy link
Contributor

jreback commented Aug 24, 2014

this is fine

the idea is that all module level functions should be available on TestCase (and vice versa)

you can prob do this automatically

by creating methods for all assert_* in the module on TestCase

Make assert_numpy_array_equivalent available without subclassing TestCase; see #8023
@jreback jreback added this to the 0.15.1 milestone Aug 29, 2014
@jorisvandenbossche
Copy link
Member

@jreback is this OK to merge?

I think the automatic adding of methods to TestCase can be done later in another PR, this is just adding the two test functions to the main testing namespace

@bwignall Can you squash the two commits?

@jreback
Copy link
Contributor

jreback commented Nov 28, 2014

yep this is ok

@jorisvandenbossche
Copy link
Member

@bwignall sorry, I forgot this PR, and it is now already merged as part of another one, see #8923
But thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants