-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
harmonize the testing namespace with tm.TestCase #8023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
yep, some of these are added, but the inherting from TestCase is pretty recent so the entire conversion hasn't been done yet. (converting the usage of |
I haven't looked at this yet, I just started to look at the failing tests in statsmodels. I don't think inheriting from TestCase makes sense for statsmodels. What we need is the equivalent of the numpy.testing assert_xxx functions. |
|
TST: changed *args, **kwargs to fixed arguments. pandas-dev#8023 TST: Moved rest of the test functions to module level. pandas-dev#8023 TST: patch all module level assert functions to TestCase. pandas-dev#8023 CLN: Cleanup TestCase assert functions pathing pandas-dev#8023
Closed by #8923 |
Currently these two have different places to look for the relevant equality tests:
TestCase
hasassert_numpy_array_equivalent
andassert_numpy_array_equal
but the testing module hasassert_frame_equal
andassert_series_equal
.It would be nice if all substantial code is available form the testing module and
TestCase
implements a small wrapper around these methods. That way someone outside pandas can importtm
and us ethe methods without subclassingTestCase
.The text was updated successfully, but these errors were encountered: