Skip to content

Deprecate detection of IPython frontends #7499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2014

Conversation

takluyver
Copy link
Contributor

The check for the Qt console won't be necessary in IPython 3 and above: we decided that the Qt console's display of HTML reprs was so bad that it shouldn't attempt to show them. We also want to remove the parent_appname config value (ipython/ipython#4980), which will break both of these functions (making them always return False).

The assignment to ipnbh was redundant - nothing used that variable. I guess it was used previously and didn't get cleaned up during some changes (quite possibly my own omission).

@jorisvandenbossche
Copy link
Member

About the qtconsole, then this issue #7372 can maybe closed? (which is a nice illustration of how bad it can be ...)

@takluyver
Copy link
Contributor Author

I've rebased this pull request - I think it's ready for review.

@jreback
Copy link
Contributor

jreback commented Jun 24, 2014

is their a min ipython version that this requires? (we don't test this per se), e.g. will this break with an older version of ipython but pandas 0.14.1/master?

@jreback jreback added this to the 0.14.1 milestone Jun 24, 2014
@takluyver
Copy link
Contributor Author

I've not actually changed anything functionally (the assignment I removed is an unused variable), so no, it won't break.

When IPython 3.0 has been out for a while, I'll make another PR to remove this code. This deprecation is just to ensure pandas doesn't start using this functionality for anything new while we're removing it.

@jreback
Copy link
Contributor

jreback commented Jun 24, 2014

so if someone uses ipython 0.11 it will still work the same?

@takluyver
Copy link
Contributor Author

Yes - this PR should not change how anything actually works whatsoever. All it does is:

  • Add deprecation notes in comments and docstrings
  • Remove an assignment to an unused variable

jreback added a commit that referenced this pull request Jun 24, 2014
Deprecate detection of IPython frontends
@jreback jreback merged commit c079290 into pandas-dev:master Jun 24, 2014
@jreback
Copy link
Contributor

jreback commented Jun 24, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants