Skip to content

Commit c079290

Browse files
committed
Merge pull request #7499 from takluyver/ipy-no-detect-frontend
Deprecate detection of IPython frontends
2 parents a6ba456 + 77e8abd commit c079290

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

pandas/core/common.py

+5
Original file line numberDiff line numberDiff line change
@@ -2599,6 +2599,8 @@ def check_main():
25992599
def in_qtconsole():
26002600
"""
26012601
check if we're inside an IPython qtconsole
2602+
2603+
DEPRECATED: This is no longer needed, or working, in IPython 3 and above.
26022604
"""
26032605
try:
26042606
ip = get_ipython()
@@ -2616,6 +2618,9 @@ def in_qtconsole():
26162618
def in_ipnb():
26172619
"""
26182620
check if we're inside an IPython Notebook
2621+
2622+
DEPRECATED: This is no longer used in pandas, and won't work in IPython 3
2623+
and above.
26192624
"""
26202625
try:
26212626
ip = get_ipython()

pandas/core/frame.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -470,14 +470,12 @@ def _repr_html_(self):
470470
Return a html representation for a particular DataFrame.
471471
Mainly for IPython notebook.
472472
"""
473-
# ipnb in html repr mode allows scrolling
474-
# users strongly prefer to h-scroll a wide HTML table in the browser
475-
# then to get a summary view. GH3541, GH3573
476-
ipnbh = com.in_ipnb() and get_option('display.notebook_repr_html')
477-
478473
# qtconsole doesn't report it's line width, and also
479474
# behaves badly when outputting an HTML table
480475
# that doesn't fit the window, so disable it.
476+
# XXX: In IPython 3.x and above, the Qt console will not attempt to
477+
# display HTML, so this check can be removed when support for IPython 2.x
478+
# is no longer needed.
481479
if com.in_qtconsole():
482480
# 'HTML output is disabled in QtConsole'
483481
return None

0 commit comments

Comments
 (0)