-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH/API: offsets funcs now accepts datetime64 #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm their is a vbench for this I dont recall exactly the speed issue wrt to datetime/dagetime64 but their is a closed issue about it - can u zref the issue and make sure that nothing has changed thxs |
xref. #6592 |
Following is the vbench result. I understand #6592 added 2 separate logic for If we compare CC @bjonen
|
related to #6318 ? |
@sinhrks can you post the benches that relate to this? |
@hayd Looks different, this is for
|
ENH/API: offsets funcs now accepts datetime64
Even though
CustomBusinessDay.apply
can handlenp.datetime64
, most of other offsets cannot acceptdatetime64
and raisesApplyTypeError
. The fix allows all offsetsapply
,rollforward
androllback
to handlenp.datetime64
properly.NOTE:
CustomBusinessDay
had separate logic fordatetime
andnp.datetime64
. Based on the comparison using current master,np.datetime64
logic looks slower. Thus I removed it.