Skip to content

Improve performance for custom business days (GH6584) #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2014

Conversation

bjonen
Copy link
Contributor

@bjonen bjonen commented Mar 10, 2014

closes #6584

Tests are passing. Incrementing datetime with custom dateoffset is at about twice the speed now. This could probably be optimized more.

@jreback
Copy link
Contributor

jreback commented Mar 10, 2014

can you add a vbench . look for agood place in the vb_suite dir

@bjonen
Copy link
Contributor Author

bjonen commented Mar 11, 2014

Sure, might take a few days though. I'll let you know when I had the time to look into this.

@bjonen
Copy link
Contributor Author

bjonen commented Mar 16, 2014

I've added a small vbench to vbsuite/timeseries.py.

Btw, what is the standard way to run vbsuite on the last commit? I did

%run test_perf.py -t 6305492393 -b 391ed32 -r timeseries

timeseries_custom_bday_incr | 0.0157 | 0.0353 | 0.4437 |

Perhaps it would be good to add some hints on how to use vbench, which script to run etc.

@jreback
Copy link
Contributor

jreback commented Mar 17, 2014

@jreback
Copy link
Contributor

jreback commented Mar 17, 2014

pls add a release notes entry under enhancements, referencing #6584

@jreback jreback added this to the 0.14.0 milestone Mar 17, 2014
@jreback jreback changed the title Improve performance for custom business days (see #6584) Improve performance for custom business days (GH6584) Mar 17, 2014
@bjonen
Copy link
Contributor Author

bjonen commented Mar 17, 2014

I've added the release note and rebased. Do you want me to squash this into one commit?

Also, I have started to implement pandas.offsets.CustomBusinessMonth. Should I open a separate PR for this or keep going here?

@jreback
Copy link
Contributor

jreback commented Mar 17, 2014

pls squash

open a new PR/issue for different CustomBusinessMonth

@bjonen
Copy link
Contributor Author

bjonen commented Mar 18, 2014

Ok done

jreback added a commit that referenced this pull request Mar 18, 2014
Improve performance for custom business days (GH6584)
@jreback jreback merged commit f0055c5 into pandas-dev:master Mar 18, 2014
@jreback
Copy link
Contributor

jreback commented Mar 18, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom-business-days offsets very slow
2 participants