-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Improve performance for custom business days (GH6584) #6592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can you add a vbench . look for agood place in the vb_suite dir |
Sure, might take a few days though. I'll let you know when I had the time to look into this. |
I've added a small vbench to vbsuite/timeseries.py. Btw, what is the standard way to run vbsuite on the last commit? I did %run test_perf.py -t 6305492393 -b 391ed32 -r timeseries timeseries_custom_bday_incr | 0.0157 | 0.0353 | 0.4437 | Perhaps it would be good to add some hints on how to use vbench, which script to run etc. |
pls add a release notes entry under enhancements, referencing #6584 |
I've added the release note and rebased. Do you want me to squash this into one commit? Also, I have started to implement |
pls squash open a new PR/issue for different |
Ok done |
Improve performance for custom business days (GH6584)
thanks! |
closes #6584
Tests are passing. Incrementing datetime with custom dateoffset is at about twice the speed now. This could probably be optimized more.