Skip to content

FIX: resample with fill_method and how #2073 #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2014
Merged

FIX: resample with fill_method and how #2073 #7341

merged 1 commit into from
Jun 4, 2014
+14 −0

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 4, 2014

closes #2073

@cpcloud cpcloud mentioned this pull request Jun 4, 2014
Closed
@cpcloud
Copy link
Member Author

cpcloud commented Jun 4, 2014

@jreback ok with this?

@jreback jreback added this to the 0.14.1 milestone Jun 4, 2014
@jreback
Copy link
Contributor

jreback commented Jun 4, 2014

ok

cpcloud added a commit that referenced this pull request Jun 4, 2014
@cpcloud
Merge pull request #7341 from cpcloud/hayd-gh2073
2c2809d 
FIX: resample with fill_method and how #2073
@cpcloud cpcloud merged commit 2c2809d into pandas-dev:master Jun 4, 2014
@cpcloud
Copy link
Member Author

cpcloud commented Jun 4, 2014

@hayd thanks

@cpcloud cpcloud deleted the hayd-gh2073 branch June 4, 2014 19:47
@jreback
Copy link
Contributor

jreback commented Jun 4, 2014

fyi, don't use range in test comparisons (fails on windows)

c5c4478

@cpcloud
Copy link
Member Author

cpcloud commented Jun 4, 2014

why is that?

@jreback
Copy link
Contributor

jreback commented Jun 4, 2014

because range is a generator, so its kind of like do np.arange(..) on a 32-bit platform gives you 32-bit ints (which then don't compare properly) of course on 64-bit it gives you 64-bits. lists otoh give 64-bit (its only numpy arrays and generators which do this)

@cpcloud
Copy link
Member Author

cpcloud commented Jun 4, 2014

ok good 2 know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Resample resample method
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

Up-sampling and filling while also passing the "how" parameter
3 participants
@cpcloud @jreback @hayd