FIX resample with fill_method and how #2073 #7273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just needs a whatsnew note otherwise looks good |
DOC add to release notes
|
@hayd status on this? i can take it if you want ... pretty much done. passing on travis |
|
If you've done it push it! :) |
|
ok closing in favor of #7341 (basically just your commits but re run) |
|
Great, thanks! confused at the travis: IIRC travis passed, then I squished in some release notes, then it failed. |
|
looks like a random failure ... since you didn't really touch any of the period index stuff you're just calling fillna which shouldn't change any keys ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2073