Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API: Rename
arg
tofunc
inSeries.map
#61264New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Rename
arg
tofunc
inSeries.map
#61264Changes from 7 commits
cf6d36b
adb0982
c5d44f6
fed4ace
1d758e6
092e9c0
e12c726
0796d9f
5f270b3
843668e
cbe2c68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting this won't be backwards compatible with the use
Series.map(arg=foo, func=myfunc)
wheremyfunc
is an argument offoo
. This seems unlikely enough that I am okay here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are totally right. In my first implementation I was raising an exception, and then thought it would be better to allow using
arg
as an argument name of the udf. If we want to be very conservative we could raise now, and stop raising when we remove the deprecation andarg
is no longer accepted as the argument name of the function.But as you, I think is better to just let that unlikely case break compatibility.