-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: Rename arg
to func
in Series.map
#61264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 11 commits into
pandas-dev:main
from
datapythonista:series_map_func_param
Apr 14, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cf6d36b
API: Rename `arg` to `func` in `Series.map`
datapythonista adb0982
Merge remote-tracking branch 'upstream/main' into series_map_func_param
datapythonista c5d44f6
mypy
datapythonista fed4ace
Merge branch 'main' into series_map_func_param
datapythonista 1d758e6
Moving release note to deprecations
datapythonista 092e9c0
Merge remote-tracking branch 'upstream/main' into series_map_func_param
datapythonista e12c726
Merge branch 'series_map_func_param' of github.com:datapythonista/pan…
datapythonista 0796d9f
Update doc/source/whatsnew/v3.0.0.rst
datapythonista 5f270b3
Fix CI
datapythonista 843668e
Fix CI
datapythonista cbe2c68
Fix CI
datapythonista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting this won't be backwards compatible with the use
Series.map(arg=foo, func=myfunc)
wheremyfunc
is an argument offoo
. This seems unlikely enough that I am okay here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are totally right. In my first implementation I was raising an exception, and then thought it would be better to allow using
arg
as an argument name of the udf. If we want to be very conservative we could raise now, and stop raising when we remove the deprecation andarg
is no longer accepted as the argument name of the function.But as you, I think is better to just let that unlikely case break compatibility.