Skip to content

Backport PR #60940: ENH: Add dtype argument to str.decode #60968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

JakeTT404 and others added 7 commits February 10, 2025 16:51
…edge case in HDFStore.append (pandas-dev#60829)

* Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code.

* Fix missed tests and correct mistake in error message.

* Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function.

(cherry picked from commit 57340ec)
@rhshadrach rhshadrach added this to the 2.3 milestone Feb 19, 2025
@rhshadrach rhshadrach added Strings String extension data type and string data Enhancement labels Feb 19, 2025
Comment on lines +1998 to +1999
Specifies the error handling scheme.
Possible values are those supported by :meth:`bytes.decode`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc created the conflict; not part of the origin PR I'm backporting but I figure why not add it.

@mroeschke mroeschke merged commit 81229e6 into pandas-dev:2.3.x Feb 20, 2025
44 of 53 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the auto-backport-of-pr-60940-on-2.3.x branch February 20, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants