-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: remove usage of legacy NPY_PROMOTION_STATE #60144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove usage of legacy NPY_PROMOTION_STATE #60144
Conversation
CI is passing, except for the pyarrow nightly build, which seems to be using numpy 1.26 |
Looks like I added a If that works, maybe we can also remove the |
The Arrow nightly build seems a good one to use a later numpy version, but it might still be useful to test 1.26 somewhere? |
This is all passing, so going to merge this to get CI green again. But I still think we ideally get the tests passing for numpy 1.26 as well (at some point our min version might be that version and we will test with it anyway. But will open a separate follow-up PR for that) |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
(cherry picked from commit 4bbb3ce)
Manual backport -> #60153 |
We no longer need this, see also discussion in #60140.
And this fixes CI on main (tests are currently failing if you use numpy >= 2 with this env variable set)