Skip to content

TST: Fix some test builds for numpy 2.0 #59046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Jun 18, 2024
@mroeschke mroeschke added this to the 2.2.3 milestone Jun 18, 2024
@lithomas1
Copy link
Member

Looks like some of the adjusted tests are causing some failures.

@mroeschke
Copy link
Member Author

Had to pin numpy on the pyarrow dev build; we can plan to tackle the test failures in that build along with the other builds once they pull in numpy 2.0 by default. Going to merge to get to green

@mroeschke mroeschke merged commit b1e5f06 into pandas-dev:main Jun 24, 2024
41 checks passed
@mroeschke mroeschke deleted the tst/np/2 branch June 24, 2024 21:07
Copy link

lumberbot-app bot commented Jun 24, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b1e5f0636ab2cc3e6949a051e37dc289616a4a4f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #59046: TST: Fix some test builds for numpy 2.0'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-59046-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #59046 on branch 2.2.x (TST: Fix some test builds for numpy 2.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants