BLD: relax meson/meson-python requirements #60089
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |
| # Minimum requirements for the build system to execute. | ||
| # See https://github.com/scipy/scipy/pull/12940 for the AIX issue. | ||
| requires = [ | ||
| "meson-python>=0.13.1,<0.14", | ||
| "meson>=1.2.1,<2", | ||
|
There was a problem hiding this comment. This one looks right to me. Note that newer Meson versions have more shiny features one may want (e.g., you need 1.4.0 to have There was a problem hiding this comment. I vaguely remember trying to upgrade this in #57895 and running into issues; we might want to keep the pin here below 1.4.0 since that has some fundamental changes to how NumPy is integrated (or on the flip side, bump the min to 1.4.0, although that would be a larger task) There was a problem hiding this comment. Feel free to bump and make that change as well :) |
||
| "wheel", | ||
| "Cython~=3.0.5", # Note: sync with setup.py, environment.yml and asv.conf.json | ||
| # Force numpy higher than 2.0rc1, so that built wheels are compatible | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're at 0.17.0 already (with 0.17.1 coming later today). Normally in
mainone should not add upper bounds at all, and at most all them in release branches only. So I'd drop the upper bound here completely. If Pandas devs are attached to it, then it should be<0.18.The lower bound can be left as is or bumped, since 0.13.1 is pretty old by now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be OK to remove the upper bound