Skip to content

BLD: relax meson/meson-python requirements #60089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

BLD: relax meson/meson-python requirements #60089

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83c87d
relax meson/meson-python requirements
isuruf Oct 23, 2024
dd120cb
Drop upper bound for meson-python
isuruf Oct 25, 2024
bc2e87a
Merge branch 'main' into meson
isuruf Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Minimum requirements for the build system to execute.
# See https://github.com/scipy/scipy/pull/12940 for the AIX issue.
requires = [
"meson-python==0.13.1",
"meson==1.2.1",
"meson-python>=0.13.1",
"meson>=1.2.1,<2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks right to me. Note that newer Meson versions have more shiny features one may want (e.g., you need 1.4.0 to have dependency('numpy') work with numpy 2.0 and up, so could be bumped a bit as well if desired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember trying to upgrade this in #57895 and running into issues; we might want to keep the pin here below 1.4.0 since that has some fundamental changes to how NumPy is integrated (or on the flip side, bump the min to 1.4.0, although that would be a larger task)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to bump and make that change as well :)

"wheel",
"Cython~=3.0.5", # Note: sync with setup.py, environment.yml and asv.conf.json
# Force numpy higher than 2.0rc1, so that built wheels are compatible
Expand Down
Loading