Skip to content

CI: Uninstall nomkl & 32 bit Interval tests #59553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 20, 2024
Merged

CI: Uninstall nomkl & 32 bit Interval tests #59553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39ce222
undo numpy 2 changes?
mroeschke Aug 19, 2024
2a751da
some interval 32 bit tests working
mroeschke Aug 19, 2024
2414bfd
Revert "undo numpy 2 changes?"
mroeschke Aug 19, 2024
bcac38c
nomkl?
mroeschke Aug 19, 2024
c961d08
nomkl?
mroeschke Aug 19, 2024
c0ac174
Update .github/actions/build_pandas/action.yml
mroeschke Aug 19, 2024
21ebdba
grep for nomkl
mroeschke Aug 20, 2024
50e9f4e
xfail WASM
mroeschke Aug 20, 2024
df7e70a
Reverse condition
mroeschke Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/actions/build_pandas/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ runs:
fi
shell: bash -el {0}

- name: Uninstall nomkl
run: |
if conda list nomkl | grep nomkl 1>/dev/null; then
conda remove nomkl -y
fi
shell: bash -el {0}
Comment on lines +25 to +30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke do you remember why this was needed? (I don't see anything in the PR description or discussion)

Copy link
Member Author

@mroeschke mroeschke Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some test failures during this time e.g. https://github.com/pandas-dev/pandas/actions/runs/10460069892/job/28965469092 were due to some transitive dependency pulling in nomkl (I don't know why nomkl caused these tests to fail but uninstalling the package allowed those tests to pass again)


- name: Build Pandas
run: |
if [[ ${{ inputs.editable }} == "true" ]]; then
Expand Down
7 changes: 5 additions & 2 deletions pandas/tests/indexes/interval/test_interval_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
import pytest

from pandas._libs.interval import IntervalTree
from pandas.compat import IS64
from pandas.compat import (
IS64,
WASM,
)

import pandas._testing as tm

Expand Down Expand Up @@ -186,7 +189,7 @@ def test_construction_overflow(self):
expected = (50 + np.iinfo(np.int64).max) / 2
assert result == expected

@pytest.mark.xfail(not IS64, reason="GH 23440")
@pytest.mark.xfail(WASM, reason="GH 23440")
@pytest.mark.parametrize(
"left, right, expected",
[
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/indexing/interval/test_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import pytest

from pandas._libs import index as libindex
from pandas.compat import IS64
from pandas.compat import WASM

import pandas as pd
from pandas import (
Expand Down Expand Up @@ -210,7 +210,7 @@ def test_mi_intervalindex_slicing_with_scalar(self):
expected = Series([1, 6, 2, 8, 7], index=expected_index, name="value")
tm.assert_series_equal(result, expected)

@pytest.mark.xfail(not IS64, reason="GH 23440")
@pytest.mark.xfail(WASM, reason="GH 23440")
@pytest.mark.parametrize("base", [101, 1010])
def test_reindex_behavior_with_interval_index(self, base):
# GH 51826
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/indexing/interval/test_interval_new.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np
import pytest

from pandas.compat import IS64
from pandas.compat import WASM

from pandas import (
Index,
Expand Down Expand Up @@ -214,7 +214,7 @@ def test_loc_getitem_missing_key_error_message(
obj.loc[[4, 5, 6]]


@pytest.mark.xfail(not IS64, reason="GH 23440")
@pytest.mark.xfail(WASM, reason="GH 23440")
@pytest.mark.parametrize(
"intervals",
[
Expand Down