Skip to content

CI: Uninstall nomkl & 32 bit Interval tests #59553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 20, 2024
Merged

CI: Uninstall nomkl & 32 bit Interval tests #59553

merged 9 commits into from
Aug 20, 2024

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Interval Interval data type 32bit 32-bit systems labels Aug 19, 2024
@mroeschke mroeschke added this to the 2.2.3 milestone Aug 19, 2024
@mroeschke mroeschke changed the title CI: Fix numpy 2.0.1(?) test failures & 32 bit Interval tests CI: Uninstall nomkl & 32 bit Interval tests Aug 20, 2024
@jbrockmendel
Copy link
Member

looks like the un-xfailed tests are still complaining on the pyiodide build. that has numpy 1.26; are other builds now using newer numpys?

@mroeschke
Copy link
Member Author

Yeah it looks like the closest equivalent 32 bit build is using numpy 2.1.0. I'll just xfail these tests for WASM for now until numpy 2 is installed

@mroeschke
Copy link
Member Author

Merging to get the CI back to green

@mroeschke mroeschke merged commit 1044cf4 into pandas-dev:main Aug 20, 2024
47 checks passed
@mroeschke mroeschke deleted the ci/np/compat branch August 20, 2024 20:32
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Aug 20, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1044cf442109953987c1a47f476dc90d286b9f0f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #59553: CI: Uninstall nomkl & 32 bit Interval tests'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-59553-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #59553 on branch 2.2.x (CI: Uninstall nomkl & 32 bit Interval tests)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 20, 2024
@mroeschke
Backport PR pandas-dev#59553: CI: Uninstall nomkl & 32 bit Interval t…
829e4c3 
…ests
mroeschke added a commit that referenced this pull request Aug 21, 2024
@mroeschke
Backport PR #59553: CI: Uninstall nomkl & 32 bit Interval tests (#59570)
dc47602 
* Backport PR #59553: CI: Uninstall nomkl & 32 bit Interval tests

* Update pandas/tests/indexes/interval/test_interval_tree.py

* Update pandas/tests/indexes/interval/test_interval_tree.py

* Update pandas/tests/indexing/interval/test_interval_new.py

* Update pandas/tests/indexing/interval/test_interval_new.py
@mroeschke mroeschke mentioned this pull request Aug 22, 2024
Merged
jorisvandenbossche
jorisvandenbossche reviewed Oct 30, 2024
View reviewed changes
.github/actions/build_pandas/action.yml
Comment on lines +25 to +30
- name: Uninstall nomkl
run: |
if conda list nomkl | grep nomkl 1>/dev/null; then
conda remove nomkl -y
fi
shell: bash -el {0}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke do you remember why this was needed? (I don't see anything in the PR description or discussion)

Copy link
Member Author

@mroeschke mroeschke Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some test failures during this time e.g. https://github.com/pandas-dev/pandas/actions/runs/10460069892/job/28965469092 were due to some transitive dependency pulling in nomkl (I don't know why nomkl caused these tests to fail but uninstalling the package allowed those tests to pass again)

@jorisvandenbossche jorisvandenbossche mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
32bit 32-bit systems CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jbrockmendel @jorisvandenbossche