DEPR: keep_default_dates and convert_dates in read_json #59349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the lack of review, but one quick feedback item: when deprecating something, we initially need to keep the functionality working (but with raising a warning when the user specifies the keyword), and the actual code only gets removed in a later stage (in the next major release). |
|
No problem, thank you for the message. I unassigned myself on the issue and wrote a message explaining it, it might be a little bit too high for my current level and I don't want to keep it blocked. I will check out old pull requests for deprecations following your feedback. |
|
Thanks for the PR but it appears to have gone stale. Going to close but please let us know if you'd like to continue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #59161
(NOT TOTALLY DONE THIS IS A DRAFT PULL REQUEST ... THE DESCRIPTION WILL BE DONE IN PROFESSIONAL LANGUAGE IF I CAN GET TO THE ACTUAL PULL REQUEST)
New contributor and self-taught non-professional programmer who loves pandas and fixed a few tests here in 2022.
The part not finished yet = refactoring
dtypeconversion to useinfer_dtypeinstead ofastypeguessing ... reading the directions closely enough to get the development environment built correctly took a while and then I've made quite a few changes and am a little bit confused about the aforementioned part and was hoping to get the other changes checked in order to make sure that I am on the correct path.I tried to delete instances of
keep_default_datesandconvert_datesin parameters, calls, and corresponding tests ofread_jsonand in related functions, so that it will fall back on usingdtypeconversions from the ujson parser, while keeping the functions and tests intact whenever they are not totally dependent onkeep_default_datesandconvert_dates.convert_datesalso exists in a file forsas7bdatand in parts of the code involvingStata, but not as part of theread_jsonfunction in such cases, so I am pretty sure that these are separate but I wanted to check.