-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: keep_default_dates
and convert_dates
in read_json
#59161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
read_json
keep_default_dates
and convert_dates
in read_json
taking this issue |
@Animesh-Shukla are you still working on this? Your take was from a few weeks ago so I think that I am going to take this since I contributed on here a while ago and want to start again. If you still want it or want to work on it together, let me know! |
you can take it @phershbe |
take |
I have most of a draft pull request mentioned here, but some tests are not passing so I am working on identifying the reasons and fixing them |
I created a pull request but have struggled with this issue, I don't want to keep in blocked so I unassigned myself in case anybody else would like to work on it. |
read_json
hasconvert_dates
,keep_default_dates
anddtypes
that all try to perform dtype conversions on the result from the ujson parser. Conflicts can arise when a column matching the specification ofkeep_default_dates
matches a column specified indtypes
.The proposal is to deprecate
keep_default_dates
andconvert_dates
and only usedtype
's current definition ofTrue
: attempt dtype conversion on all column (and refactor to useinfer_dtype
instead ofastype
guessing)False
: perform no dtype conversiondict
: dict keys that match column labels will be cast to type in the dict valueThe text was updated successfully, but these errors were encountered: