PERF: Series(dict) returns RangeIndex when possible #58118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Index
WillAyd
requested changes
Apr 3, 2024
| np_sequence = np.asarray(sequence, dtype=np.int64) | ||
| try: | ||
| np_sequence = np.asarray(sequence, dtype=np.int64) | ||
| except OverflowError: |
There was a problem hiding this comment.
Why is the OverflowError required in this case? Have we added that elsewhere to support the RangeIndex return?
There was a problem hiding this comment.
This line will fail if the sequence contains an int over the max int64 value e.g. test_loc_uint64.
This is the only pathway that can convert an arbitrary sequence to a RangeIndex return
WillAyd
approved these changes
Apr 3, 2024
|
Thanks @mroeschke |
1 task
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441