Skip to content

Potential regression induced by "PERF: Series(dict) returns RangeIndex when possible" #58150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DeaMariaLeon opened this issue Apr 4, 2024 · 2 comments
Closed

Potential regression induced by "PERF: Series(dict) returns RangeIndex when possible" #58150

DeaMariaLeon opened this issue Apr 4, 2024 · 2 comments
Labels
Benchmark Performance (ASV) benchmarks

Comments

@DeaMariaLeon
Copy link
Member

PR #58118

If it is expected please ignore this issue.

Benchmark:
series_methods.SeriesConstructor.time_constructor_dict - no permutations
http://57.128.112.95:5000/compare/benchmarks/0660daf33c6478af8000779f25acbd4d...0660dd6fa43276cc8000cdfdb5c270dc

@mroeschke

Screenshot 2024-04-04 at 17 00 28
@DeaMariaLeon DeaMariaLeon added the Benchmark Performance (ASV) benchmarks label Apr 4, 2024
@mroeschke
Copy link
Member

Thanks for the ping! I think the increase in time is due to inference done on the dict.keys to determine if the keys are integers. I am not sure if this can be avoided but can take a second look later

@mroeschke mroeschke mentioned this issue Apr 17, 2024
Closed
1 task
@mroeschke
Copy link
Member

Closing as I didn't find a way to avoid this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @DeaMariaLeon