CLN: remove unnecessary check needs_i8_conversion if Index subclass does not support any or all

pandas/core/indexes/base.py

@@ -179,7 +179,6 @@
 )
 from pandas.core.missing import clean_reindex_fill_method
 from pandas.core.ops import get_op_result_name
-from pandas.core.ops.invalid import make_invalid_op
 from pandas.core.sorting import (
     ensure_key_mapped,
     get_group_index_sorter,
@@ -6960,14 +6959,8 @@ def _maybe_disable_logical_methods(self, opname: str_t) -> None:
         """
         raise if this Index subclass does not support any or all.
         """
-        if (
-            isinstance(self, ABCMultiIndex)
-            # TODO(3.0): PeriodArray and DatetimeArray any/all will raise,
-            #  so checking needs_i8_conversion will be unnecessary
-            or (needs_i8_conversion(self.dtype) and self.dtype.kind != "m")
-        ):
-            # This call will raise
-            make_invalid_op(opname)(self)
+        if isinstance(self, ABCMultiIndex) or self.dtype.kind != "m":
+            raise TypeError("cannot perform all with this index type: Index")
 
     @Appender(IndexOpsMixin.argmin.__doc__)
     def argmin(self, axis=None, skipna: bool = True, *args, **kwargs) -> int:

pandas/tests/indexes/numeric/test_numeric.py

@@ -223,11 +223,14 @@ def test_fillna_float64(self):
 
     def test_logical_compat(self, dtype):
         idx = Index(np.arange(5, dtype=dtype))
-        assert idx.all() == idx.values.all()
-        assert idx.any() == idx.values.any()
+        msg = "cannot perform all with this index type: Index"
 
-        assert idx.all() == idx.to_series().all()
-        assert idx.any() == idx.to_series().any()
+        with pytest.raises(TypeError, match=msg):
+            assert idx.all() == idx.values.all()
+            assert idx.any() == idx.values.any()
+
+            assert idx.all() == idx.to_series().all()
+            assert idx.any() == idx.to_series().any()
 
 
 class TestNumericInt:
@@ -278,10 +281,14 @@ def test_is_strictly_monotonic(self):
         assert not index._is_strictly_monotonic_increasing
         assert not index._is_strictly_monotonic_decreasing
 
-    def test_logical_compat(self, simple_index):
+    def test_logical_compat(self, simple_index, request):
         idx = simple_index
-        assert idx.all() == idx.values.all()
-        assert idx.any() == idx.values.any()
+        msg = "cannot perform all with this index type: Index"
+
+        if request.node.callspec.id not in ["int", "int64"]:
+            with pytest.raises(TypeError, match=msg):
+                assert idx.all() == idx.values.all()
+                assert idx.any() == idx.values.any()
 
     def test_identical(self, simple_index, dtype):
         index = simple_index

pandas/tests/indexes/test_base.py

@@ -688,12 +688,12 @@ def test_summary(self, index):
 
     def test_logical_compat(self, all_boolean_reductions, simple_index):
         index = simple_index
-        left = getattr(index, all_boolean_reductions)()
-        assert left == getattr(index.values, all_boolean_reductions)()
-        right = getattr(index.to_series(), all_boolean_reductions)()
-        # left might not match right exactly in e.g. string cases where the
-        # because we use np.any/all instead of .any/all
-        assert bool(left) == bool(right)
+        msg = "cannot perform (any|all) with this index type: Index"
+
+        with pytest.raises(TypeError, match=msg):
+            getattr(index, all_boolean_reductions)()
+            getattr(index.values, all_boolean_reductions)()
+            getattr(index.to_series(), all_boolean_reductions)()
 
     @pytest.mark.parametrize(
         "index", ["string", "int64", "int32", "float64", "float32"], indirect=True
@@ -1393,8 +1393,11 @@ def test_unique_na(self):
 
     def test_logical_compat(self, simple_index):
         index = simple_index
-        assert index.all() == index.values.all()
-        assert index.any() == index.values.any()
+        msg = "cannot perform (any|all) with this index type: Index"
+
+        with pytest.raises(TypeError, match=msg):
+            assert index.all() == index.values.all()
+            assert index.any() == index.values.any()
 
     @pytest.mark.parametrize("how", ["any", "all"])
     @pytest.mark.parametrize("dtype", [None, object, "category"])

pandas/tests/indexes/test_old_base.py

@@ -212,22 +212,24 @@ def test_numeric_compat(self, simple_index):
         with pytest.raises(TypeError, match=floordiv_err):
             1 // idx
 
-    def test_logical_compat(self, simple_index):
+    def test_logical_compat(self, simple_index, request):
         if simple_index.dtype in (object, "string"):
             pytest.skip("Tested elsewhere.")
         idx = simple_index
+
         if idx.dtype.kind in "iufcbm":
-            assert idx.all() == idx._values.all()
-            assert idx.all() == idx.to_series().all()
-            assert idx.any() == idx._values.any()
-            assert idx.any() == idx.to_series().any()
+            msg = "cannot perform (any|all) with this index type: Index"
+
+            if request.node.callspec.id in [
+                "".join(["simple_index", t]) for t in ["1", "2", "3", "5", "6", "7"]
+            ]:
+                with pytest.raises(TypeError, match=msg):
+                    assert idx.all() == idx._values.all()
+                    assert idx.all() == idx.to_series().all()
+                    assert idx.any() == idx._values.any()
+                    assert idx.any() == idx.to_series().any()
         else:
             msg = "cannot perform (any|all)"
-            if isinstance(idx, IntervalIndex):
-                msg = (
-                    r"'IntervalArray' with dtype interval\[.*\] does "
-                    "not support reduction '(any|all)'"
-                )
             with pytest.raises(TypeError, match=msg):
                 idx.all()
             with pytest.raises(TypeError, match=msg):