CLN: enforce any/all deprecation with datetime64
#58029
Conversation
pandas/core/arrays/datetimelike.py
Outdated
| @@ -1665,12 +1665,7 @@ def _groupby_op( | |||
| raise TypeError(f"datetime64 type does not support {how} operations") | |||
| if how in ["any", "all"]: | |||
There was a problem hiding this comment.
Could you combine this if with the one above?
There was a problem hiding this comment.
Yeah, sure. Done
pandas/core/nanops.py
Outdated
| FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| ) | ||
| raise TypeError("datetime64 type does not support any operations") |
There was a problem hiding this comment.
| raise TypeError("datetime64 type does not support any operations") | |
| raise TypeError("datetime64 type does not support operation: 'all'") |
There was a problem hiding this comment.
This should probably be 'any' instead since this is for nanany?
There was a problem hiding this comment.
Yea sorry - but my suggestion applies to both the any and all implementations. does not support (any|all) operations is ambiguous language whereas does not support operation: (any|all) is clearer
There was a problem hiding this comment.
thank you, I agree, the new wording looks much better. I used the message "does not support (any|all) operations" because it was the original error message from _groupby_op and I didn't want to change it.
I corrected the messages as you suggested.
|
Thanks @natmokval |
* enforce deprecation any/all with datetime64, correct tests * add a note to v3.0.0 * enforce depr any/all with dt64 in groupby * combine two if * change wording in the error msg * fix test_in_numeric_groupby * fix test_cython_transform_frame_column
xref #50947, xref #58006
enforced deprecation of
any/allwithdatetime64