PERF: Remove slower short circut checks in RangeIndex__getitem__ #57856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the
all()
andnot any()
checks were supposed to be for short-circuiting, I think these cases are not common enough to always check in this if branch. Thenot any()
check will get reduced bynp.flatnonzero
. Theall()
check cannot short circuit unlike the check in_shallow_copy
.A probably more "common case":
The worst case where
if key.all()
would have gotten hit (will be improved by #57812)