Skip to content

Potential regression induced by PR #57588 #57712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DeaMariaLeon opened this issue Mar 3, 2024 · 1 comment · Fixed by #57856
Closed

Potential regression induced by PR #57588 #57712

DeaMariaLeon opened this issue Mar 3, 2024 · 1 comment · Fixed by #57856
Labels
Benchmark Performance (ASV) benchmarks

Comments

@DeaMariaLeon
Copy link
Member

DeaMariaLeon commented Mar 3, 2024

PR #57588

If this is expected please ignore this issue.

The largest regressions seem to be the benchmarks bellow.
edit: the names of all the benchmarks with links to their plot are in the attached file.

series_methods.Dropna.time_dropna (Python) with dtype='datetime'
groupby.GroupByMethods.time_dtype_as_field (Python) with application='direct', dtype='int16', method='head', ncols=1, param5='cython'
groupby.Nth.time_series_nth_all (Python) with dtype='datetime'

@mroeschke

cleaned_regression_file.json

Screenshot 2024-03-03 at 13 26 15

@DeaMariaLeon DeaMariaLeon added the Benchmark Performance (ASV) benchmarks label Mar 3, 2024
@mroeschke
Copy link
Member

Thanks for the tag. This Is expected as there is more work done to potentially return a RangeIndex instead of an Index but I'll double check once more if some of that work can be minimized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants