-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: RangeIndex.append returns a RangeIndex when possible #57467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
907cda6
PERF: RangeIndex.append returns a RangeIndex when possible
mroeschke 91dd97c
add correct issue number
mroeschke 06880f3
add correct issue number
mroeschke 45eb9dc
Merge remote-tracking branch 'upstream/main' into perf/ri/_concat_more
mroeschke bfb101d
Only if int
mroeschke ce1cc0b
Merge remote-tracking branch 'upstream/main' into perf/ri/_concat_more
mroeschke 042215f
Merge remote-tracking branch 'upstream/main' into perf/ri/_concat_more
mroeschke 51e91eb
Merge remote-tracking branch 'upstream/main' into perf/ri/_concat_more
mroeschke b12e877
Guard on integer dtype kind
mroeschke 176a95c
Add test for return Index case
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think it can be useful to also add a test for the case where it can't return a
RangeIndex
but anIndex
maybe we can add it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea; I think that would be useful. Added a test in the latest commit