PERF: RangeIndex.append returns a RangeIndex when possible #57467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, do you want to fix the conflict here @mroeschke |
datapythonista
approved these changes
Mar 6, 2024
Comment on lines
+612
to
+614
| ri = RangeIndex(1) | ||
| result = ri.append(Index([1])) | ||
| expected = RangeIndex(2) |
There was a problem hiding this comment.
If you think it can be useful to also add a test for the case where it can't return a RangeIndex but an Index maybe we can add it.
There was a problem hiding this comment.
Good idea; I think that would be useful. Added a test in the latest commit
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…v#57467) * PERF: RangeIndex.append returns a RangeIndex when possible * add correct issue number * add correct issue number * Only if int * Guard on integer dtype kind * Add test for return Index case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #57441