Skip to content

Remove DataFrame.swapaxes #57363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Remove DataFrame.swapaxes #57363

merged 2 commits into from
Feb 12, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 11, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added this to the 3.0 milestone Feb 11, 2024
@mroeschke mroeschke merged commit 8207bd2 into pandas-dev:main Feb 12, 2024
@mroeschke
Copy link
Member

Thanks @phofl

assert len(np.array_split(o, 5)) == 5
assert len(np.array_split(o, 2)) == 2
assert len(np.array_split(o, 5)) == 5
assert len(np.array_split(o, 2)) == 2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi 👋 ref numpy/numpy#24889 (comment)

after this PR, calling np.array_split(df) will no longer return list[pd.DataFrame], but list[np.ndarray]. this was not tested here ^

could you fix the split compat? currently, this PR poses quite a nasty breaking change with no obvious migration / alternative at hand.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Remove swapaxes

* Remove swapaxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants